Restructure THFMDataSource and fix potential crash #63

Merged

dsonck merged 3 commits from bugfix/close-not-resetting-packet-remaining into development 2024-03-03 20:25:13 +00:00

Conversation 1 Commits 3 Files changed 3 +101 -134

dsonck commented 2024-03-03 20:21:41 +00:00 (Migrated from git.touhou.fm)

Copy link

• Restructure THFMDataSource and fix potential crash

  Simplify the packet receive function to try receive
  60 times, and reconnect after every failure.
  Also clear out the socket and available bytes marker
  on close().

• Remove Thread in favor of a coroutine

• Remove unnecessary permission

* Restructure THFMDataSource and fix potential crash Simplify the packet receive function to try receive 60 times, and reconnect after every failure. Also clear out the socket and available bytes marker on close(). * Remove Thread in favor of a coroutine * Remove unnecessary permission

dsonck (Migrated from git.touhou.fm) scheduled this pull request to auto merge when all checks succeed 2024-03-03 20:22:02 +00:00

dsonck commented 2024-03-03 20:25:10 +00:00 (Migrated from git.touhou.fm)

Copy link

mentioned in commit 940eb089db

mentioned in commit 940eb089db2bd8cbdbaff4343426d74117d5a2e6

dsonck (Migrated from git.touhou.fm) merged commit 940eb089db into development 2024-03-03 20:25:13 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Feature

  

Protocol

Protocol related things

  

status

accepted

  

status

doing

  

status

on-hold

No labels

Feature

Protocol

status

accepted

status

doing

status

on-hold

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

touhou.fm/fm.touhou.touhoufm!63

No description provided.